gtsam: add v4.2.0a9, update package options #17933

valgur · 2023-06-14T13:33:41Z

Adds v4.2.0a9.
Adds transitive_headers=True and transitive_libs=True where necessary.
Went thoroughly over all build options used in the build scripts and updated the package options based on these.
- Should be mostly pretty straightforward. The only exception is the deprecation of allow_deprecated_since_V4 in favor of allow_deprecated. This param gets replaced with an incremented new param in each version of the library while the meaning stays the same, so it made more sense to me to simplify it to one stable option name.
Added a missing program_options Boost component requirement.
Dropped v4.0.2 to speed up the full CI build a bit. It's superseded by v4.0.3.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

See https://github.com/borglab/gtsam/blob/4.1.1/cmake/HandleBoost.cmake#L26

ghost · 2023-06-14T13:37:47Z

I detected other pull requests that are modifying gtsam/all recipe:

gtsam: Add options new options #17931

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

https://github.com/borglab/gtsam/releases/tag/4.2a9

- Covers all options that could be found in GTSAM build scripts. - Added links to source code since they are hard to find otherwise. - Added `allow_deprecated` option and deprecated `allow_deprecated_since_V4` as the wording of the GTSAM variable keeps changing but the meaning has stayed the same. - Added vars: GTSAM_DEFAULT_ALLOCATOR GTSAM_SLOW_BUT_CORRECT_BETWEENFACTOR GTSAM_USE_SYSTEM_METIS GTSAM_MEX_BUILD_STATIC_MODULE

AbrilRBS

Thanks a lot! Not approving yet as I still need to check the package_info method but ran out of time, will circle back to it in a few days, but so far so good!

AbrilRBS · 2023-07-12T22:25:20Z

recipes/gtsam/all/conandata.yml

+    - patch_file: "patches/4.2.0a9-0001-fix-invalid-include.patch"
+      patch_description: "Fix an invalid include for pre-C++17 compatibility"
+      patch_type: "portability"
+      patch_source: "https://github.com/borglab/gtsam/pull/1545"


Great catch! Thanks for porting it upstream :)

AbrilRBS · 2023-07-12T22:30:14Z

recipes/gtsam/all/conanfile.py

+            self.options.rm_safe("use_vendored_metis")
+        elif not self.options.use_vendored_metis:
+            # GTSAM expects 32-bit integers for Metis
+            self.options["metis"].with_64bit_types = False


Could you post logs of this configuration building correctly please? CCI's CI won't get to try these combinations, and it would be great to have some proof for future maintenance which shows that some of the new options were tested properly

Hmm, it no longer builds with the new metis recipe, unfortunately. I'm reverting that feature for now and will possibly add it in a future PR instead.

Hi @valgur! Is this happening because of the latest Metis recipe version? Could we fix that before removing that option?

I think so, yes. I intend to look into the Metis issue, but I would leave that for a separate PR, since this one is quite comprehensive already. It's not affecting any existing functionality in the GTSAM recipe anyway.

recipes/gtsam/all/conanfile.py

It no longer builds with the new metis recipe.

conan-center-bot · 2023-08-03T12:24:56Z

Conan v1 pipeline ✔️

All green in build 6 (8b7d26a50d3594bff3b1e450d42c2bfeba6f7c00):

gtsam/4.1.1@:
All packages built successfully! (All logs)
gtsam/4.2.0a9@:
All packages built successfully! (All logs)
gtsam/4.0.3@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 6 (8b7d26a50d3594bff3b1e450d42c2bfeba6f7c00):

gtsam/4.0.3@:
All packages built successfully! (All logs)
gtsam/4.2.0a9@:
All packages built successfully! (All logs)
gtsam/4.1.1@:
All packages built successfully! (All logs)

franramirez688 · 2023-08-04T09:05:49Z

recipes/gtsam/all/conandata.yml

@@ -1,14 +1,28 @@
 sources:
+  "4.2.0a9":


@valgur I realized that the official version is 4.2a9, should not it be better to put the same one? Am I missing something?

I based it on the full version number in CMakeLists.txt: https://github.com/borglab/gtsam/blob/4.2a9/CMakeLists.txt#L10-L13
My reasoning was that the official release is going to be 4.2.0, so this would be slightly more consistent and would avoid potential ambiguity when sorting the version numbers.
I don't have anything against renaming it to 4.2a9 either, though.

* gtsam: add missing Boost::program_options requirement See https://github.com/borglab/gtsam/blob/4.1.1/cmake/HandleBoost.cmake#L26 * gtsam: add transitive_headers/libs to deps * gtsam: drop test_v1_package * gtsam: backport a patch for C++17 compatibility * gtsam: add v4.2.0a9 https://github.com/borglab/gtsam/releases/tag/4.2a9 * gtsam: update package options - Covers all options that could be found in GTSAM build scripts. - Added links to source code since they are hard to find otherwise. - Added `allow_deprecated` option and deprecated `allow_deprecated_since_V4` as the wording of the GTSAM variable keeps changing but the meaning has stayed the same. - Added vars: GTSAM_DEFAULT_ALLOCATOR GTSAM_SLOW_BUT_CORRECT_BETWEENFACTOR GTSAM_USE_SYSTEM_METIS GTSAM_MEX_BUILD_STATIC_MODULE * gtsam: tweak formatting * gtsam: get rid of a duplicate patch * gtsam: handle `build_type_postfixes` option correctly * gtsam: correct metis lib name in 4.0 * gtsam: correct build_type_postfixes behavior * gtsam: fix a bug in 4.2.0a9 * gtsam: add 'lib' prefix to libraries on Windows * gtsam: add patch_source info to conandata.yml * gtsam: apply "lib" prefix on Windows correctly * gtsam: drop v4.0.2 To limit the load on CI. Superseded by v4.0.3. * gtsam: update onetbb and boost versions onetbb/2020.3 did not support Conan v2. * gtsam: better TBB validation * gtsam: add tcmalloc support with gperftools * gtsam: fix Eigen version check * gtsam: enable shared builds on Windows for v4.2 * gtsam: shared builds on Windows are broken in v4.2.0a9 * gtsam: document options with options_description * gtsam: add use_vendored_metis option * gtsam: simplify Conan v1 boilerplate * gtsam: improve default_allocator handling * gtsam: remove use_vendored_metis option It no longer builds with the new metis recipe. --------- Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

valgur added 2 commits June 14, 2023 16:30

gtsam: add missing Boost::program_options requirement

379f867

See https://github.com/borglab/gtsam/blob/4.1.1/cmake/HandleBoost.cmake#L26

gtsam: add transitive_headers/libs to deps

bca797e

ghost mentioned this pull request Jun 14, 2023

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Jun 14, 2023

gtsam: Add options new options #17931

Closed

2 tasks

prince-chrismc mentioned this pull request Jun 14, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

gtsam: drop test_v1_package

b0d6a4a

valgur force-pushed the gtsam/recipe-fixes branch from 3cdaad6 to eb041bc Compare June 15, 2023 08:18

conan-center-bot added the Failed label Jun 15, 2023

This comment has been minimized.

Sign in to view

valgur added 2 commits June 15, 2023 14:16

gtsam: backport a patch for C++17 compatibility

8538d81

gtsam: add v4.2.0a9

f764397

https://github.com/borglab/gtsam/releases/tag/4.2a9

valgur force-pushed the gtsam/recipe-fixes branch from eb041bc to 9e7c0e3 Compare June 15, 2023 11:16

valgur changed the title ~~gtsam: minor fixes~~ gtsam: add v4.2.0a9, update package options Jun 15, 2023

This comment has been minimized.

Sign in to view

valgur added 4 commits June 15, 2023 15:24

gtsam: tweak formatting

54774bb

gtsam: get rid of a duplicate patch

a1fc0f8

gtsam: handle build_type_postfixes option correctly

26e7ded

valgur force-pushed the gtsam/recipe-fixes branch from 7317737 to 26e7ded Compare June 15, 2023 13:12

This was referenced Jun 15, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Open

This comment has been minimized.

Sign in to view

ericLemanissier mentioned this pull request Jun 15, 2023

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

This comment has been minimized.

Sign in to view

valgur added 3 commits June 15, 2023 18:14

gtsam: correct metis lib name in 4.0

2eaccc3

gtsam: correct build_type_postfixes behavior

5f37a67

gtsam: fix a bug in 4.2.0a9

559483f

AbrilRBS reviewed Jul 12, 2023

View reviewed changes

valgur commented Jul 14, 2023

View reviewed changes

recipes/gtsam/all/conanfile.py Outdated Show resolved Hide resolved

gtsam: remove use_vendored_metis option

b9eccbe

It no longer builds with the new metis recipe.

valgur requested review from AbrilRBS and jwillikers July 21, 2023 16:24

This comment has been minimized.

Sign in to view

AbrilRBS requested review from franramirez688 and removed request for jwillikers and AbrilRBS July 22, 2023 03:02

conan-center-bot added the Service Under Maintenance label Jul 24, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into gtsam/recipe-fixes

6ef35f5

franramirez688 self-assigned this Jul 26, 2023

conan-center-bot added Failed and removed Service Under Maintenance labels Jul 26, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into gtsam/recipe-fixes

8b7d26a

conan-center-bot added Service Under Maintenance and removed Failed labels Aug 3, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Aug 3, 2023

valgur requested a review from AbrilRBS August 3, 2023 12:49

franramirez688 reviewed Aug 4, 2023

View reviewed changes

franramirez688 approved these changes Aug 4, 2023

View reviewed changes

SSE4 approved these changes Aug 6, 2023

View reviewed changes

conan-center-bot merged commit bc1eb90 into conan-io:master Aug 6, 2023
5 checks passed

valgur deleted the gtsam/recipe-fixes branch January 15, 2024 06:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gtsam: add v4.2.0a9, update package options #17933

gtsam: add v4.2.0a9, update package options #17933

valgur commented Jun 14, 2023 •

edited

Loading

ghost commented Jun 14, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment •

edited

Loading

AbrilRBS Jul 12, 2023

AbrilRBS Jul 12, 2023 •

edited

Loading

valgur Jul 21, 2023

franramirez688 Aug 3, 2023

valgur Aug 3, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 3, 2023

franramirez688 Aug 4, 2023

valgur Aug 4, 2023

gtsam: add v4.2.0a9, update package options #17933

gtsam: add v4.2.0a9, update package options #17933

Conversation

valgur commented Jun 14, 2023 • edited Loading

ghost commented Jun 14, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

AbrilRBS Jul 12, 2023

Choose a reason for hiding this comment

AbrilRBS Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

valgur Jul 21, 2023

Choose a reason for hiding this comment

franramirez688 Aug 3, 2023

Choose a reason for hiding this comment

valgur Aug 3, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 3, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

franramirez688 Aug 4, 2023

Choose a reason for hiding this comment

valgur Aug 4, 2023

Choose a reason for hiding this comment

valgur commented Jun 14, 2023 •

edited

Loading

AbrilRBS left a comment •

edited

Loading

AbrilRBS Jul 12, 2023 •

edited

Loading