Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to monitor a registry with a tag filter #197

Closed
wants to merge 1 commit into from
Closed

feat: Add the ability to monitor a registry with a tag filter #197

wants to merge 1 commit into from

Conversation

jghiloni
Copy link

@jghiloni jghiloni commented Jun 5, 2020

Somewhat related to the conversation(?) in #151, this PR provides the pipeline author a way to monitor a registry image for new tags, and to use that for the get criterion. This has been tested against public and private repos.

Signed-off-by: Josh Ghiloni <jghiloni@pivotal.io>
@vito vito self-assigned this Jun 8, 2020
@jghiloni
Copy link
Author

jghiloni commented Jun 9, 2020

Let's call this WIP for now -- I realized this doesn't help for anything other than check scripts, I want to be able to handle pinning, as well as adding the tag to the in metadata

@vito
Copy link
Member

vito commented Jun 10, 2020

@jghiloni I think right now this doesn't really address #151 - which is fine, it doesn't have to, and what's here is still useful since it allows you to specify what is effectively still a fixed tag to track - except it works by determining the tag via a regexp and using semver ordering to pick the latest one that matches, rather than specifying a static tag value.

In contrast, #151 is almost an entirely different versioning model, where it would return each semver tag as its own version in semver-order. In that model, if you wanted to pin to a specific version you could say version: {tag: 1.2.3} in image_resource, on a get step, or in the resource definition (alongside source:). You might still want something like tag_filter to filter the versions that it returns though.

@vito
Copy link
Member

vito commented Jun 21, 2020

@jghiloni Just FYI, #151 has been on my weekend to-do list for a while so I'm taking a swing at it now! Just thought I'd ping in case you had also started looking into it beyond what's done here so far. Happy to hold off if you are.

@jghiloni
Copy link
Author

jghiloni commented Jun 22, 2020 via email

@vito
Copy link
Member

vito commented Jul 15, 2020

@jghiloni #214 is just about ready if you'd like to take a look! Curious to know whether the semver pattern matches your use case.

@jghiloni
Copy link
Author

It's exactly our use case, would love to give it a shot when you get a chance.

@vito vito mentioned this pull request Jul 15, 2020
12 tasks
@vito vito closed this in #214 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants