Skip to content
This repository has been archived by the owner on Jan 30, 2019. It is now read-only.

Fix unexpected prune parameter in pip installer. #246

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Fix unexpected prune parameter in pip installer. #246

merged 1 commit into from
Jun 15, 2016

Conversation

kdeldycke
Copy link
Contributor

prune keyword parameter has been added in e01ba6f / #190, but only for the regular conda installer.

Because it's missing from the pip installer, we end up with the following traceback:

Traceback (most recent call last):
  File "/home/travis/miniconda/bin/conda-env", line 6, in <module>
    sys.exit(conda_env.cli.main.main())
  File "/home/travis/miniconda/lib/python2.7/site-packages/conda_env/cli/main.py", line 68, in main
    return args_func(args, parser)
  File "/home/travis/miniconda/lib/python2.7/site-packages/conda/cli/main.py", line 127, in args_func
    args.func(args, p)
  File "/home/travis/miniconda/lib/python2.7/site-packages/conda_env/cli/main_update.py", line 118, in execute
    installer.install(prefix, specs, args, env, prune=args.prune)
TypeError: install() got an unexpected keyword argument 'prune'

Source: https://travis-ci.org/kdeldycke/chessboard/jobs/137781307#L481-L490

This PR fix the call to the pip installer.

@msarahan
Copy link
Collaborator

Good fix. The dangers of not having a good api isolation layer...

@msarahan msarahan merged commit 9823030 into conda-archive:develop Jun 15, 2016
@kdeldycke kdeldycke deleted the pip-installer-unexpected-prune-param branch June 15, 2016 12:51
@kdeldycke
Copy link
Contributor Author

Thanks for the merge! :)

Should we expect a 2.5.1 bug fix release soon?

@msarahan
Copy link
Collaborator

Yeah, I think this bug is enough to warrant a release.

Have you come across any other issues?

On Wed, Jun 15, 2016, 07:51 Kevin Deldycke notifications@github.com wrote:

Thanks for the merge! :)

Should we expect a 2.5.1 bug fix release soon?


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#246 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AACV-cxhoZ9vmwA5_f2kWETNa5BPBIMaks5qL_VjgaJpZM4I2UXk
.

@kdeldycke
Copy link
Contributor Author

No issue so far. My builds were all successful before the 2.5.0 released.

kdeldycke pushed a commit to kdeldycke/chessboard that referenced this pull request Jun 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants