Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two broken packages which have broken hash #946

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julian-belina
Copy link

@julian-belina julian-belina commented Feb 22, 2024

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed

@julian-belina julian-belina requested a review from a team as a code owner February 22, 2024 13:09
@julian-belina
Copy link
Author

julian-belina commented Feb 22, 2024

Hello,

I would like to mark the build of these two packages as broken. Unfortunately, the tags to the commits of both recipes has been deleted and now point to another commit. So the hashes are no longer valid.

@conda-forge/ethos_penalps
@conda-forge/geokit
I am maintainer for both of these packages so I hope its okay to mark the checklist.

@jaimergp
Copy link
Member

Tags should be immutable and we can't replace versions with new commits. It's better to cut a new release (e.g. 1.0.1) addressing the problem. If upstream decided to do it differently, in conda-forge we could add a 1.0.post1 but in general the rule goes by "once tagged, assume it can be packaged as such".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants