Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency for typed-ast #44

Closed
wants to merge 1 commit into from

Conversation

deantvv
Copy link
Contributor

@deantvv deantvv commented Jul 26, 2022

typed-ast has an issue which will lead to error: undefined symbol _PyUnicode_DecodeUnicodeEscape

They fix this error in 1.5.0, so here comes the update.

typed-ast has an [issue](python/typed_ast#169 (comment))
which will lead to error: undefined symbol _PyUnicode_DecodeUnicodeEscape

They fix this error in `1.5.0`, so here comes the update.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@deantvv
Copy link
Contributor Author

deantvv commented Jul 28, 2022

@carlodri Could you take a look at this?

@carlodri
Copy link
Contributor

carlodri commented Jul 28, 2022

Hi @deantvv, thanks for the PR. Not sure how to deal with this properly, since the error seems to occur only with Python 3.9.8, and black should depend on typet-ast only for Python < 3.8. This is because the recipe has been made noarch. The proper way should be remove the noarch and constrain the typed-ast as appropriate, but that has a resource cost (CI particularly). @conda-forge/black what do yo think?

@deantvv
Copy link
Contributor Author

deantvv commented Jul 29, 2022

@carlodri I only understood that the error only occurs with Python 3.9.8 and typed-ast 1.4.x after you mentioned it.
Since Python 3.9.8 is not available on both conda and conda-forge channels, and typed-ast isn't needed after Python > 3.8. It seems this PR is unnecessary. But there is still cases when people (like me) maintain a local conda channel, that still provide Python 3.9.8 and when the solver use that unfortunate combination (python=3.9.8, typed-ast=1.4.*, black), people will scratch their head for several minutes only to find the fix is conda install typed-ast=1.5. IMO, since typed-ast make a new release for this fix, it's worth it for black to bump dependency.
I also agree with you to drop the noarch: python part, instead of fixing this stuff. Since there is several packages that aren't needed for newer version of python like dataclasses, typed-ast, typing_extensions and also tomli.
Anyway, thanks for the quick respond and the reasoning for not update them. 🙏🙏

@deantvv
Copy link
Contributor Author

deantvv commented Aug 1, 2022

Closing this. Follow up #46 by @carlodri

@deantvv deantvv closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants