Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a larger hana struct_macros.hpp header #208

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jun 24, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit funny that we need a whole other language to regenerate one header...

recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@isuruf isuruf merged commit 67119c5 into conda-forge:main Jun 25, 2024
8 checks passed
@isuruf
Copy link
Member Author

isuruf commented Jun 25, 2024

Thanks

@isuruf isuruf deleted the large_hana branch June 25, 2024 01:14
@robambalu
Copy link

This is great. In order to pick this up will the latest conda boost package just have this by default, or does one need to opt-in to getting the version with the increased hana struct size?

@isuruf
Copy link
Member Author

isuruf commented Jun 26, 2024

The latest conda boost package will have this by default.

@h-vetinari
Copy link
Member

The latest conda boost package will have this by default.

We aren't migrating for boost 1.85, so this will not be usable if you have packages in your environment that depend on libboost. But it would be easy to backport this PR to the v1.84.x branch, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants