Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.20.0 #12

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Update to v0.20.0 #12

merged 2 commits into from
Oct 22, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Oct 22, 2022

With this update, we no longer use the cartopy_offlinedata package, we just download the data using cartopy itself.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

closes #11

@xylar xylar requested a review from willirath as a code owner October 22, 2022 10:21
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

@willirath, I've put in a PR that should add the antarctic ice shelves to cartopy downloads: SciTools/cartopy#2097

In the meantime, there's a script here to do that.

I'm downloading the cartopy source code here just so the bot will keep us in sync, though we don't really need to build a new package for every cartopy version.

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

I'm running some tests with some downstream software (https://github.com/MPAS-Dev/MPAS-Analysis) to make sure there are no surprises.

@willirath
Copy link
Contributor

I'm downloading the cartopy source code here just so the bot will keep us in sync, though we don't really need to build a new package for every cartopy version.

I agree. But closely following cartopy releases also provides immediate warning when cartopy changes anything that breaks our workflow here.

xylar and others added 2 commits October 22, 2022 12:29
With this update, we no longer use the cartopy_offlinedata package,
we just download the data using cartopy itself.
@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

But closely following cartopy releases also provides immediate warning when cartopy changes anything that breaks our workflow here.

Yep, good point. We can always make sure CI passes for each cartopy release even if we just close the PR after that.

Copy link
Contributor

@willirath willirath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@willirath
Copy link
Contributor

All checks passing. @xylar do you want to do more tests, or should we merge?

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

I got kicked off of the supercomputer where I was doing the testing without explanation! I'll try again elsewhere.

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

I think my testing job is going to time out before it finishes but it would have shown a bunch of Download warnings if things weren't working.

@xylar xylar merged commit dbd01f4 into conda-forge:main Oct 22, 2022
@xylar xylar deleted the update_to_0.20.0 branch October 22, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is finally (largely) obsolete 🎉
3 participants