Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against both ogre 1.12 and 1.10 #85

Merged
merged 12 commits into from
Jul 20, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jul 19, 2021

This will probably be necessary in any case to install gazebo in a ros2 environement with rviz2 installed. However, my main interest right now is to debug the ogre 1.12 build of conda-forge (for RoboStack/ros-galactic#24), as I already had experience in using Gazebo with Ogre 1.12 built via vcpkg, so it is more familiar for me to debug any problem here.

I tried to use track_features to de-prioritize ogre 1.12, but I am not sure if this actually works, but I gave it a shot.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title Build both against ogre 1.12 and 1.10 Build against both ogre 1.12 and 1.10 Jul 19, 2021
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues, please ping conda-forge/core
for further assistance. You can also try re-rendering locally.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-linter and others added 2 commits July 19, 2021 21:08
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@traversaro
Copy link
Contributor Author

I suspect all the failure are unrelated to the actual PR and related to conda-forge/qwt-feedstock#28 . Let's try with a clean build.

@traversaro traversaro merged commit 13e5686 into conda-forge:master Jul 20, 2021
@traversaro traversaro deleted the bump-ogre-1-12 branch July 20, 2021 05:47
@traversaro
Copy link
Contributor Author

The track_features aspect seems to work, if I install conda create -n gazebo gazebo or mamba create -n gazebo gazebo I get the ogre 1.10 version, but with conda create -n gazebo gazebo ogre=1.12 or mamba create -n gazebo gazebo ogre 1.12 I get the ogre 1.12 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants