Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #19

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5140655335, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

jakirkham commented Jun 1, 2023

Noticed the following error on CI:

- Encountered problems while solving:
-   - package cuda-version-12.0-hffde075_0 has constraint cudatoolkit 12.0|12.0.* conflicting with cudatoolkit-9.2.148-h80a95b2_6

This is expected as cudatoolkit doesn't exist for CUDA 12.0+ (it only exists for CUDA 11 and earlier). Guessing this is related to cudatoolkit on this line

host:
- boost-cpp
- cudatoolkit # [cuda_compiler_version != "None"]

The cuda-version package (referenced in the error message above) supplants the CUDA alignment function that cudatoolkit had previously ( conda-forge/conda-forge.github.io#687 ). If one's main goal is CUDA version alignment, cuda-version can be used for this (and it works on all CUDA versions that have been built in conda-forge including new ones).

On the other hand, if the goal is to make sure cudatoolkit is around for linking in the host environment when building for CUDA 11. That should already be handled by {{ compiler("cuda") }}, which adds cudatoolkit to host and run automatically

If there is some other goal in including cudatoolkit here, happy to discuss what other options might make sense

Edit: For more info about the CUDA 12 bringup, please see issue ( conda-forge/conda-forge.github.io#1963 )

@carterbox
Copy link
Member

@conda-forge-admin, please rerender

@carterbox
Copy link
Member

@conda-forge-admin, please rerender

@carterbox carterbox added the automerge Merge the PR when CI passes label Jun 7, 2023
@carterbox carterbox merged commit 29a2a54 into conda-forge:main Jun 8, 2023
@jakirkham
Copy link
Member

Thanks Daniel! 🙏

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_h8540ee branch June 8, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants