Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python311 #48

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3394028299, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@IAlibay
Copy link
Contributor

IAlibay commented Nov 4, 2022

@orbeckst @richardjgowers - we never tested against py3.11 with 2.3.0, I would be of the opinion that we don't do this and wait for 2.4.0 for the release that will support py3.11.

@orbeckst
Copy link
Contributor

orbeckst commented Nov 4, 2022

ok... let's get a 2.4.0 out.

(Do we need a pyedr cf package?)

@IAlibay
Copy link
Contributor

IAlibay commented Nov 4, 2022

ok... let's get a 2.4.0 out.

(Do we need a pyedr cf package?)

v2.4.0 is due for the first of December, so the freeze will be called in ~ 2 weeks?

pyedr yes, I want to get MDAnalysis/panedr#55 merged, then I'll cut a 0.7.1 release and move on with conda-forge things.

@ocefpaf ocefpaf merged commit 68cdc0c into conda-forge:main Nov 4, 2022
@ocefpaf
Copy link
Member

ocefpaf commented Nov 4, 2022

Argh! Clicked here by accident! Do we need to revert/mark as borken? (I should not review stuff on my cellphone!)

@IAlibay
Copy link
Contributor

IAlibay commented Nov 4, 2022

Argh! Clicked here by accident! Do we need to revert/mark as borken? (I should not review stuff on my cellphone!)

@ocefpaf I'm not actually seeing a runner for py3.11, is there a build even happening for it?

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python311-0-1_h232afa branch November 4, 2022 19:24
@ocefpaf
Copy link
Member

ocefpaf commented Nov 4, 2022

@ocefpaf I'm not actually seeing a runner for py3.11, is there a build even happening for it?

Indeed! See https://github.com/conda-forge/mdanalysis-feedstock/blob/main/recipe/meta.yaml#L17

I guess that the bot should not even send a PR here b/c it skips Python 3.10 and above.

@IAlibay
Copy link
Contributor

IAlibay commented Nov 4, 2022

I completely forgot we had that skip on, that's fortunately saved things (I don't think our pyproject.toml would have supported a py3.11 build for now anyways).

@orbeckst @richardjgowers - I'm happy not reverting this PR for now and leaving this as-is? We can just leverage the bot's work when we do 2.4.0?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 4, 2022

I'm happy not reverting this PR for now and leaving this as-is? We can just leverage the bot's work when we do 2.4.0?

That is a good idea BTW. When mdanalysis is ready for py310 and py311 you can just remove the skip and rerender. If you revert, you'll need to wait for another bot PR or to migrate it manually.

@orbeckst
Copy link
Contributor

orbeckst commented Nov 4, 2022

Yes, we can keep it, apart from increasing the build number, nothing really happened, right? (No untested 3.11 package.)

@orbeckst orbeckst mentioned this pull request Nov 4, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants