-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 19.1.0-rc3 release #34
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
f6fb88e
to
db0181c
Compare
Also, |
My guess is in |
d0dbcc1
to
45323d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to review the docs for creating a pre-release build for conda-forge. It seems like all the missing packages such as llvm
, llvmdev
and mlir
have the llvm_rc
label applied, and the version number is 19.1.0.rc3
.
recipe/meta.yaml
Outdated
|
||
package: | ||
name: mlir-python-bindings | ||
version: {{ version }} | ||
|
||
source: | ||
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-{{ version.replace(".rc", "-rc") }}/llvm-project-{{ version.replace(".rc", "rc") }}.src.tar.xz | ||
sha256: 0b58557a6d32ceee97c8d533a59b9212d87e0fc4d2833924eb6c611247db2f2a | ||
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0-rc3/llvm-project-19.1.0-rc3.src.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0-rc3/llvm-project-19.1.0-rc3.src.tar.xz | |
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-{{ version.replace(".rc", "-rc") }}/llvm-project-{{ version.replace(".rc", "-rc") }}.src.tar.xz |
recipe/meta.yaml
Outdated
@@ -1,18 +1,18 @@ | |||
{% set version = "18.1.8" %} | |||
{% set version = "19.1.0rc3" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% set version = "19.1.0rc3" %} | |
{% set version = "19.1.0.rc3" %} |
This file is probably already in the |
45323d2
to
6688c4d
Compare
Thank you! It looks like it's building for most environments. Once it finishes current CI jobs I will move your commit here. One question: Should this PR target
Exactly! |
We'd have to wait until
I pushed a commit -- it should now build for all environments. |
Superseded by #35 |
Hi @hameerabbasi,
In this PR I would like to add llvm 19.1.0rc3 (which should be officially released in a week I think) to the conda-forge. I'm not sure if these are all changes required.