Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 19.1.0-rc3 release #34

Closed
wants to merge 1 commit into from
Closed

Conversation

mtsokol
Copy link

@mtsokol mtsokol commented Aug 30, 2024

Hi @hameerabbasi,

In this PR I would like to add llvm 19.1.0rc3 (which should be officially released in a week I think) to the conda-forge. I'm not sure if these are all changes required.

@mtsokol mtsokol requested review from jim22k and a team as code owners August 30, 2024 09:12
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mtsokol mtsokol force-pushed the add-version-19 branch 4 times, most recently from f6fb88e to db0181c Compare August 30, 2024 09:45
@mtsokol
Copy link
Author

mtsokol commented Aug 30, 2024

Also, site-packages/mlir/_mlir_libs/include only has mlir-c directory, I think we also need mlir there, and libmlir_c_runner_utils.so should be available there.

@mtsokol
Copy link
Author

mtsokol commented Aug 30, 2024

My guess is in recipe/build.sh cmake command needs to be updated.

Copy link
Contributor

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to review the docs for creating a pre-release build for conda-forge. It seems like all the missing packages such as llvm, llvmdev and mlir have the llvm_rc label applied, and the version number is 19.1.0.rc3.

recipe/meta.yaml Outdated

package:
name: mlir-python-bindings
version: {{ version }}

source:
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-{{ version.replace(".rc", "-rc") }}/llvm-project-{{ version.replace(".rc", "rc") }}.src.tar.xz
sha256: 0b58557a6d32ceee97c8d533a59b9212d87e0fc4d2833924eb6c611247db2f2a
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0-rc3/llvm-project-19.1.0-rc3.src.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-19.1.0-rc3/llvm-project-19.1.0-rc3.src.tar.xz
- url: https://github.com/llvm/llvm-project/releases/download/llvmorg-{{ version.replace(".rc", "-rc") }}/llvm-project-{{ version.replace(".rc", "-rc") }}.src.tar.xz

recipe/meta.yaml Outdated
@@ -1,18 +1,18 @@
{% set version = "18.1.8" %}
{% set version = "19.1.0rc3" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set version = "19.1.0rc3" %}
{% set version = "19.1.0.rc3" %}

@hameerabbasi
Copy link
Contributor

hameerabbasi commented Aug 30, 2024

Also, site-packages/mlir/_mlir_libs/include only has mlir-c directory, I think we also need mlir there, and libmlir_c_runner_utils.so should be available there.

This file is probably already in the mlir feedstock since it isn't specific to Python. It doesn't need to be in site-packages/mlir/_mlir_libs/include, but anywhere in $DYLD_LIBRARY_PATH should be okay if it's a .so.

@hameerabbasi
Copy link
Contributor

@mtsokol I opened #35, feel free to pull the changes into your branch if you wish.

@mtsokol
Copy link
Author

mtsokol commented Aug 30, 2024

Thank you! It looks like it's building for most environments. Once it finishes current CI jobs I will move your commit here.

One question: Should this PR target rc branch or main here?
https://conda-forge.org/docs/maintainer/knowledge_base/#creating-a-pre-release-build says "To create a dev or rc package, a PR can be issued into the dev or rc branch of the feedstock.". I think we don't care about RC for long time, once 19.1.0 is relesed we can also target main and override RC configuration here. WDYT?

This file is probably already in the mlir feedstock since it isn't specific to Python. It doesn't need to be in site-packages/mlir/_mlir_libs/include, but anywhere in $DYLD_LIBRARY_PATH should be okay if it's a .so.

Exactly! conda install conda-forge::mlir installed what I wanted.

@hameerabbasi
Copy link
Contributor

hameerabbasi commented Aug 30, 2024

I think we don't care about RC for long time, once 19.1.0 is relesed we can also target main and override RC configuration here. WDYT?

We'd have to wait until llvm, llvmdev and mlir also release on conda-forge (since they are deps), but we could probably also make that PR given that rc3 is already building, and I don't see a reason why it wouldn't be merged soon.

Once it finishes current CI jobs I will move your commit here.

I pushed a commit -- it should now build for all environments.

@mtsokol mtsokol mentioned this pull request Aug 30, 2024
5 tasks
@mtsokol
Copy link
Author

mtsokol commented Sep 2, 2024

Superseded by #35

@mtsokol mtsokol closed this Sep 2, 2024
@mtsokol mtsokol deleted the add-version-19 branch September 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants