Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for numpy 2.0 #1

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Jun 3, 2024

  1. Rebuild for numpy 2.0

    TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
    PR has updated the recipe to account for the changes (see below for details).
    The numpy 2.0 package itself is currently only available from a special release
    channel (`conda-forge/label/numpy_rc`) and will not be available on the main
    `conda-forge` channel until the release of numpy 2.0 GA.
    
    The biggest change is that we no longer need to use the oldest available numpy
    version at build time in order to support old numpy version at runtime - numpy
    will by default use a compatible ABI for the oldest still-supported numpy versions.
    
    Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a
    run requirement - this has been handled for more than two years now by a
    run-export on the numpy package itself. The migrator will therefore remove
    any occurrences of this.
    
    However, by default, building against numpy 2.0 will assume that the package
    is compatible with numpy 2.0, which is not necessarily the case. You should
    check that the upstream package explicitly supports numpy 2.0, otherwise you
    need to add a `- numpy <2.0dev0` run requirement until that happens (check numpy
    issue 26191 for an overview of the most important packages).
    
    Note that the numpy release candidate promises to be ABI-compatible with the
    final 2.0 release. This means that building against 2.0.0rc1 produces packages
    that can be published to our main channels.
    
    If you already want to use the numpy 2.0 release candidate yourself, you can do
    ```
    conda config --add channels conda-forge/label/numpy_rc
    ```
    or add this channel to your `.condarc` file directly.
    
    ### To-Dos:
      * [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility)
        * If upstream is not yet compatible with numpy 2.0, add `numpy <2.0dev0` upper bound under `run:`.
        * If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases.
        * If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`.
      * [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed.
    
    PS. If the build does not compile anymore, this is almost certainly a sign that
    the upstream project is not yet ready for numpy 2.0; do not close this PR until
    a version compatible with numpy 2.0 has been released upstream and on this
    feedstock (in the meantime, you can keep the bot from reopening this PR in
    case of git conflicts by marking it as a draft).
    regro-cf-autotick-bot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b0efc30 View commit details
    Browse the repository at this point in the history
  2. MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.1, and co…

    …nda-forge-pinning 2024.06.03.19.07.16
    regro-cf-autotick-bot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0b4e311 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    6b180d8 View commit details
    Browse the repository at this point in the history