Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 6.x #136

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Update to 6.x #136

merged 4 commits into from
Oct 18, 2022

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Oct 17, 2022 •
edited
Loading

only in pyside6 branch
@conda-forge-admin please rerender

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This was referenced Oct 17, 2022
Closed
Open
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyside2-feedstock/actions/runs/3266978963.

hmaarrfk
hmaarrfk reviewed Oct 17, 2022
View reviewed changes
recipe/meta.yaml
- sysroot_linux-64 2.17 # [linux64]
- python # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- pyside2 {{ qt_main }} # [build_platform != target_platform]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a note. this was bootstrapping hack for aarch64. You might need to remove it from the builds without it.

Ultimately, I'm not sure if they support out of tree shiboken2 seemed rather intertwined. and the two build systems seemed to feed off each other.

Copy link
Contributor Author

@jschueller jschueller Oct 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think the way to go is to build a native shiboken first then set QFP_SHIBOKEN_HOST_PATH

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [37]

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Contributor Author

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyside2-feedstock/actions/runs/3271259126.

@jschueller jschueller marked this pull request as ready for review October 18, 2022 17:43
@jschueller jschueller merged commit d9542a8 into conda-forge:pyside6 Oct 18, 2022
@jschueller jschueller deleted the 6x branch October 18, 2022 17:44
@jschueller jschueller mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk left review comments

@jan-janssen jan-janssen Awaiting requested review from jan-janssen jan-janssen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschueller @conda-forge-linter @hmaarrfk