-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 6.x #14
Update to 6.x #14
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.02.28.13.05.22
hi @conda-forge/qt-main what do you think ? note: it succeeds on the 3 main platforms, osx/arm64 is disabled for now and aarch64 timeouts |
Hey @jschueller, thanks for continuing your work here. You need to start from the current scripts and For an example of that kind of work, please take a look at this PR: conda-forge/qt-feedstock#206. |
Well, I pretty much restarted from scratch given that the build system is completely different. |
There are many patches that are necessary to make Qt work with conda environments and also for cross-compilation. So, I'm sorry but we can justify that you simply throw them away because the Qt6 system is a different one. If you want to pursue this, please open a new PR and follow the guidelines I provided above. If not, we'll try to take a look at this probably in Q2 of this year or the next one. |
First of all many thanks @jschueller for your effort in getting qt6 built here, this is great! I think the comparison of the bump from 5.12 to 5.15 to that here from 5 to 6 is not quite the same, is it? The build system indeed has changed completely, so as far as I can tell the I am sure a few people would be interested in getting Qt6 here sooner rather than later (myself included). What if the points above are addressed (potentially in a community effort), would that suffice to get the PR reviewed/merged? |
Sure, that's enough for me. As I said, the changes in build scripts and specially patches need to be well documented to move forward. |
I'd be happy to re-add relevant patches @jschueller - are you okay if I modify your fork (I think I have write access as I'm a maintainer of the qt-feedstock)? @jschueller - as a first step, I suggest to minimize the changes in the meta.yaml and leave some comments why things were added/removed. Are you happy to do that? |
@jschueller That's an amazing piece of work you've done here!! 😮 Any chances for us bystanders to see this cross the finish line anytime soon? Is there any way we could help? Thank you so much! 🙏 |
Hello, I just wanted to ask if there are currently any plans to revive this PR? :) |
This is another friendly ping – are there any news here? Is there any way in which the community can help – e.g., by starting a fundraiser? |
I created a branch on this repo called All patches need to be reviewed to see if they still apply, can be removed, or need to be kept for conda-forge. Also, tests need to be restored (this PR removed all of them).
Updating Qt/PyQt to 5.15 was a huge deal of work, so on the Spyder team we won't be looking at Qt6 for at least a year, perhaps more. And I don't know who else would be willing to do this as a paid effort, sorry. |
I think we should not create a branch here in the feedstock - if a build succeds it would be uploaded without review. |
Sure, that's a good idea too. Then the PR made out of that branch should go against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
run: | ||
- {{ pin_compatible("nss") }} # [unix] | ||
- {{ pin_compatible("nspr") }} # [unix] | ||
- openssl # [not osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this line is necessary. it will get picked up by run_export
. same with libxcb below
@@ -154,26 +97,19 @@ requirements: | |||
- mysql-devel # [not win] | |||
- postgresql # [not win] | |||
- zlib | |||
- zstd | |||
- zstd-static # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issues that required this line zstd-static
have since been resolved by h-ventinari
- gst-plugins-base | ||
- gstreamer | ||
- pulseaudio # [linux] | ||
- libglib # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somebody once told me that typically, one would require glib at build time, and that would export the requirement of libglib
.
goto #44 |
@conda-forge-admin please rerender