Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libxcb115 migration #7

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #6.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Rebuild for libxcb115 migration May 21, 2023
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label May 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@hmaarrfk
Copy link
Contributor

needs: conda-forge/qt-main-feedstock#159

@hmaarrfk
Copy link
Contributor

PS. I think that your conda_forge_config.yaml is messing with the migrator.

I think it will become more and more important as qt6 gains importantce.

If you want to, I can help setup a qt5 branch.

you would have to maintain 2 branches, but the bot would help.

@n-elie
Copy link
Contributor

n-elie commented May 23, 2023

@hmaarrfk Qt5 branch existed in the past but I set up this to have only branch to maintain, as the only difference between Qt5 and Qt6 packages is the Qt dependency. Each update, even from the bot, should be merged twice and the bot added PR only for main branch (Qt6). Isn't there a way to maintain only one branch?

@n-elie
Copy link
Contributor

n-elie commented May 23, 2023

I had a look deeper and I understand that my conda_forge_config.yaml works well for building but the migrator bot can't find this repo to open a PR because of the conditional qt-amin/qt6-main dependency. Am I right?

@hmaarrfk
Copy link
Contributor

I had a look deeper and I understand that my conda_forge_config.yaml works well for building but the migrator bot can't find this repo to open a PR because of the conditional qt-amin/qt6-main dependency. Am I right?

yes

@hmaarrfk hmaarrfk closed this May 23, 2023
@hmaarrfk hmaarrfk reopened this May 23, 2023
@github-actions github-actions bot merged commit 942cd97 into conda-forge:main May 23, 2023
@n-elie
Copy link
Contributor

n-elie commented May 23, 2023

I wonder if replacing these lines in meta.yaml would solve the problem:
From this

    - qt6-main                       # [qt==6]
    - qt-main                        # [qt==5]

To this

    - qt6-main                       # [qt==6 or qt=='']
    - qt-main                        # [qt==5 or qt=='']

@hmaarrfk
Copy link
Contributor

maybe.... i guess i feel like you are being "creative" here on this particular thing and it is likely not worth it.

these conda-smithy bugs are really hard to track down due to the fact that they are often hard to test for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants