Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for libignition-gazebo4 #14331

Merged
merged 12 commits into from
Mar 24, 2021
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 21, 2021

Related to #13551 . This adds the Ignition Gazebo simulator, the successor of the widely used Gazebo robotics simulator (http://gazebosim.org/). Ignition Gazebo is part of the ignition robotics libraries (see https://ignitionrobotics.org/).

Support for macOS and Windows is currently blocked by the following issues in dependent libraries:

So for the time being only Linux is enabled, support for the other platforms will be added as soon as the dependencies are ready.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-gazebo4) and found some lint.

Here's what I've got...

For recipes/libignition-gazebo4:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [16]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-gazebo4) and found it was in an excellent condition.

@traversaro traversaro changed the title [WIP] Add recipe for ignition-gazebo4 [WIP] Add recipe for libignition-gazebo4 Mar 21, 2021
@traversaro traversaro closed this Mar 21, 2021
@traversaro traversaro reopened this Mar 21, 2021
@traversaro traversaro changed the title [WIP] Add recipe for libignition-gazebo4 Add recipe for libignition-gazebo4 Mar 22, 2021
@traversaro
Copy link
Contributor Author

For @wolfv the approval in #14323 (comment) probably means he is ok with being a maintainer also of this recipe, for @Tobias-Fischer and @j-rivero an explicit go would be nice, thanks!

@conda-forge/help-c-cpp the recipe is ready for review.

@Tobias-Fischer
Copy link
Contributor

Fine with me :)

@traversaro
Copy link
Contributor Author

Temporary removed @j-rivero from mantainers to get this merged, @j-rivero feel free to open a issue or a PR to add you back as maintainer once the feedstock is created.

@wolfv wolfv merged commit fc232aa into conda-forge:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants