Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for Flask-SocketIO #1565

Merged
merged 5 commits into from
Sep 21, 2016
Merged

Added recipe for Flask-SocketIO #1565

merged 5 commits into from
Sep 21, 2016

Conversation

pmlandwehr
Copy link
Contributor

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flask-socketio) and found some lint.

Here's what I've got...

For recipes/flask-socketio:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flask-socketio) and found it was in an excellent condition.

about:
home: http://github.com/miguelgrinberg/Flask-SocketIO/
license: MIT
# license_file: No MANIFEST.in - see https://github.com/miguelgrinberg/Flask-SocketIO/issues/326
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


run:
- python
- setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop setuptools as it is probably not needed.


build:
preserve_egg_dir: True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please drop extra newline.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham jakirkham closed this Sep 20, 2016
@jakirkham jakirkham reopened this Sep 20, 2016
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flask-socketio) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Toggling to re-run CIs.

Note to self: The linter correctly handled this case and did not raise a merge conflict thanks to PR ( conda-forge/conda-forge-webservices#68 ).

@jakirkham jakirkham merged commit b280265 into conda-forge:master Sep 21, 2016
@pmlandwehr pmlandwehr deleted the flask-socketio branch September 21, 2016 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants