Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.32.0 #238

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Bump to 0.32.0 #238

merged 3 commits into from
Sep 13, 2024

Conversation

jdblischak
Copy link
Member

@jdblischak jdblischak commented Sep 12, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I got tired of waiting for the bot to open a PR for 0.32.0. The GitHub release happened yesterday as well as a partial PyPI release. The source tarball and other wheels were uploaded to PyPI 8 hours ago, and the conda-forge auto-tick bot is operational, so I don't know what is causing the delay.

In this PR:

  • Also bumped tiledb pin in recipe to 2.26 (you can ignore the 2.25 pins in .ci_support/ since the recipe pin supersedes them)
  • Ensured build number was 0

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jdblischak
Copy link
Member Author

Hmmm...I see that we migrated to numpy 2 for Python >= 3.9 in TileDB-Inc/TileDB-Py#2036, and the rerendering dropped the py38 build.

Are we ready to migrate the conda recipe to use numpy 2, ie #236?

@jdblischak
Copy link
Member Author

I think this should be fine. Even though we haven't migrated VCF to numpy 2 (in progress in TileDB-Inc/TileDB-VCF#762), the run exports when building against numpy 2 is very flexible: numpy>=1.21,<3

https://github.com/conda-forge/numpy-feedstock/blob/9f2a921008f6744eb19acbe9306a9e64ff9a925b/recipe/meta.yaml#L6
https://github.com/conda-forge/numpy-feedstock/blob/9f2a921008f6744eb19acbe9306a9e64ff9a925b/recipe/meta.yaml#L51

I confirmed with scipy. scipy 1.13 was transitioned to numpy 2, but I can still install scipy 1.14 with numpy 1:

# same exact scipy binary can be co-installed with either numpy 1 or 2
mamba create --dry-run -n test-np2 scipy=1.14 numpy=1
##  + numpy                1.26.4  py312heda63a1_0      conda-forge        7MB
##  + scipy                1.14.1  py312h7d485d2_0      conda-forge       18MB

mamba create --dry-run -n test-np2 scipy=1.14 numpy=2
##  + numpy                 2.1.1  py312h58c1407_0      conda-forge        8MB
##  + scipy                1.14.1  py312h7d485d2_0      conda-forge       18MB

@jdblischak
Copy link
Member Author

I have no idea where the phantom AppVeyor job is coming from. No config file was added, and AppVeyor has been deprecated in conda-forge since 2020.

@jdblischak jdblischak mentioned this pull request Sep 12, 2024
@jdblischak jdblischak closed this Sep 13, 2024
@jdblischak jdblischak reopened this Sep 13, 2024
@jdblischak
Copy link
Member Author

I asked about the phantom AppVeyor failure in the conda-forge Gitter and received confirmation that others have seen unexpected AppVeyor notifications. While this is frustrating since it makes it appear something is wrong, this won't actually affect anything.

@jdblischak jdblischak merged commit c43566a into conda-forge:main Sep 13, 2024
22 of 23 checks passed
@jdblischak jdblischak deleted the 0.32.0 branch September 13, 2024 15:42
@jdblischak
Copy link
Member Author

CI passed for c43566a and 0.32.0 binaries were uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants