Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip check for py-xgboost #191

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Fix pip check for py-xgboost #191

merged 6 commits into from
Aug 28, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Aug 26, 2024

Closes #190

Related: dmlc/xgboost#10755

  • Run pip check as part of test step
  • Remove nvidia-nccl-cu12 dependency from pyproject.toml
  • Use the correct platform tag using pip

Checklist

@hcho3
Copy link
Contributor Author

hcho3 commented Aug 26, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyunsu! 🙏

Added a suggestion below for test requirements

recipe/meta.yaml Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
@hcho3 hcho3 changed the title [WIP] Run pip check for py-xgboost Fix pip check for py-xgboost Aug 27, 2024
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyunsu! 🙏

Had minor suggestions to tidy the patches. The same strategy may be useful upstream to simplify PR review

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyunsu! 🙏

Both this and the upstream PR LGTM

Please feel free to merge when ready 🙂

@hcho3 hcho3 merged commit de61948 into conda-forge:main Aug 28, 2024
15 checks passed
@hcho3 hcho3 deleted the pip_check branch August 28, 2024 01:11
@jakirkham
Copy link
Member

Some of the builds here had failed on main even though they passed in the PR. Think this was due to unrelated changes in other packages (linkage checks that failed in the builds here). Have restarted and these appear to have cleared out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xgboost 2.1.1 is not supported on this platform
2 participants