-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip check
for py-xgboost
#191
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.08.26.19.18.07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hyunsu! 🙏
Added a suggestion below for test requirements
pip check
for py-xgboostpip check
for py-xgboost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hyunsu! 🙏
Had minor suggestions to tidy the patches. The same strategy may be useful upstream to simplify PR review
recipe/patches/0002-Remove-nvidia-nccl-cu12-from-pyproject.toml.patch
Outdated
Show resolved
Hide resolved
recipe/patches/0002-Remove-nvidia-nccl-cu12-from-pyproject.toml.patch
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hyunsu! 🙏
Both this and the upstream PR LGTM
Please feel free to merge when ready 🙂
Some of the builds here had failed on |
Closes #190
Related: dmlc/xgboost#10755
pip check
as part oftest
stepnvidia-nccl-cu12
dependency from pyproject.tomlpip
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)