fix: improve when we print brackets #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that conda has a bug where MatchSpec parsing removes everything between round brackets.
This is an issue with
rattler-buildsince we want to produce packages that are compatible.Our bracket printing algorithm was also not quite accurate because it was creating unnecessary brackets (AND should always have precedence over OR regardless of brackets or not).
This PR adds some tests and fixes this issue.
However, it might invalidate existing lockfiles. I am not sure what to do about that. One could argue, that we should also have a MatchSpecWithSource type that retains the original string.