This repository has been archived by the owner on May 9, 2023. It is now read-only.
Allow to build Consumer and Producer from Java instances
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` functions && Clean code
…` functions && Clean code
…er.fromManagedJavaProducer` functions
…mSettings` functions
sderosiaux
reviewed
Aug 22, 2022
|
general question: will we be able to continue updating from upstream if we change too many things in our fork? (they keep adding improvements & fixes, so we should port them back?) |
|
We're backporting almost everything we're changing. This will be backported too. |
guizmaii
force-pushed
the
plugins_v2
branch
2 times, most recently
from
67925c6
to
fb33fc7
Compare
strokyl
reviewed
Aug 23, 2022
|
|
||
| def make(settings: ConsumerSettings): RManaged[Blocking, ConsumerAccess] = |
There was a problem hiding this comment.
🔴
So there isn't the old make anymore?
There was a problem hiding this comment.
It's for internal use only. This shouldn't be used by zio-kafka users
gurinderu
approved these changes
Sep 2, 2022
gurinderu
pushed a commit
that referenced
this pull request
Sep 2, 2022
* Clean code * Clean code * Add `Producer.fromJavaProducer` and `Producer.fromManagedJavaProducer` functions && Clean code * Add `Consumer.fromJavaProducer` and `Consumer.fromManagedJavaProducer` functions && Clean code * Add `TransactionalProducer.fromJavaProducer` and `TransactionalProducer.fromManagedJavaProducer` functions * Maximize lazyness * Add `Consumer.javaConsumerFromSettings` and `Producer.javaProducerFromSettings` functions * review
gurinderu
pushed a commit
that referenced
this pull request
Sep 18, 2022
* Clean code * Clean code * Add `Producer.fromJavaProducer` and `Producer.fromManagedJavaProducer` functions && Clean code * Add `Consumer.fromJavaProducer` and `Consumer.fromManagedJavaProducer` functions && Clean code * Add `TransactionalProducer.fromJavaProducer` and `TransactionalProducer.fromManagedJavaProducer` functions * Maximize lazyness * Add `Consumer.javaConsumerFromSettings` and `Producer.javaProducerFromSettings` functions * review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #73