podvm: podvm_binaries - Revert s390x breakage #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-add the cross-build install (I guess specifically the arch specific gcc is the issues) so get the s390x podvm back working. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added
e2e-test
test_e2e_libvirt
bpradipt
reviewed
Apr 26, 2024
| @@ -34,6 +34,8 @@ ENV IMAGE_CHECKSUM "none" | |||
| COPY . /src | |||
|
|
|||
| WORKDIR /src/cloud-api-adaptor/podvm | |||
| # Installs add-ons for foreign target, if required | |||
| RUN ./hack/cross-build-extras.sh | |||
There was a problem hiding this comment.
Is this also needed for Dockerfile.podvm_binaries.{fedora, rhel} ?
There was a problem hiding this comment.
I'm not sure - #1741 has some discussion that shows that the RHEL podvm is being build for s390x, but maybe it's only built on s390x hardware itself? As discussed on slack and think we have a lot of inconsistency and tech-debt around this, but first switching to pull the binaries from a cache and then unifying on a single distro in upstream should help with that.
stevenhorsman
merged commit 22cb396
into
confidential-containers:main
41 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add the cross-build install (I guess specifically the arch specific gcc is the issues) so get the s390x podvm back working.