Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kcli version pinning #1866

Merged

Conversation

stevenhorsman
Copy link
Member

Switch kcli to use pip to install and pin the version we are using to avoid breaking changes

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Jun 14, 2024
@stevenhorsman
Copy link
Member Author

After #1865 gets merged, I'll need to bump the version of kcli being used

- Start pinning the kcli version to avoid our CI getting broken due to breaking changes

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Switch kcli install for all platforms to use pip,
so we can enforce version pinning.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman marked this pull request as ready for review June 17, 2024 08:15
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stevenhorsman

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

@wainersm wainersm merged commit d51e482 into confidential-containers:main Jun 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants