Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Switch to fedora and mkosi based binaries #1916

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

bpradipt
Copy link
Member

Switch to fedora base image with systemd and reuse the binaries generated for mkosi based builds.
The docker image is inspired from Kind node image

Switch to fedora base image with systemd and reuse the binaries
generated for mkosi based builds.
The docker image is inspired from Kind node image

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt
Copy link
Member Author

@stevenhorsman this should help with switching to a single distro..

@bpradipt bpradipt requested a review from huoqifeng July 10, 2024 08:48
@bpradipt
Copy link
Member Author

Does anyone have access to the license compliance report to figure out what's being flagged ?

@stevenhorsman
Copy link
Member

Does anyone have access to the license compliance report to figure out what's being flagged ?

I think it was @dcmiddle who had the FOSSA login details? We used to only get this triggered when PRs were created from branches not forks, but maybe some config has changed.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. I tried the mkosi make container and make image-container options and they seemed to work as expected. Thanks!

@bpradipt bpradipt requested a review from huoqifeng July 10, 2024 10:29
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpradipt bpradipt merged commit a4c63c9 into confidential-containers:main Jul 10, 2024
19 of 20 checks passed
@bpradipt bpradipt deleted the docker-fedora branch July 10, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants