Fix docker rate limit #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
requested changes
Mar 27, 2023
There was a problem hiding this comment.
@UnmeshDeodhar, although the patch is good, the commit message is not.
I'd suggest changing the commit message to something like:
tests: Use a specific version of the registry container
Switch to a fixed version of the registry containers, so a new version is not pulled
in every time a test runs, avoiding then hitting the docker hub rate limit.
UnmeshDeodhar
force-pushed
the
fix-docker-rate-limit
branch
from
670d915
to
a2d8776
Compare
|
/test |
1 similar comment
|
/test |
|
@UnmeshDeodhar, almost there, but it's still a very long line. Mind to break it as shown below? |
Switch to a fixed version of the registry containers, so a new version is not pulled in every time a test runs, avoiding then hitting the docker hub rate limit. Fixes: confidential-containers#182 Signed-off-by: Unmesh Deodhar <udeodhar@amd.com>
UnmeshDeodhar
force-pushed
the
fix-docker-rate-limit
branch
from
a2d8776
to
42e8c28
Compare
|
/test |
|
/test |
fidencio
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing registry to a fixed version so that we will not hit the docker hub rate limit.
Fixes: #182