Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update install instructions documentation #325

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Jan 17, 2024

This PR updates the install instruction documentation to have RELEASE_VERSION as a variable to have consistency across the document and avoid installation failures when it is not defined as a variable.

This PR updates the install instruction documentation to have
RELEASE_VERSION as a variable to have consistency across the document
and avoid installation failures when it is not defined as a variable.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT
Copy link
Contributor Author

GabyCT commented Jan 17, 2024

With consistency, I am referring to have it like other instructions in the same document as you can see here
https://github.com/confidential-containers/operator/blob/b2ec837a502413a06c88a556fea20aabd8ff5654/docs/INSTALL.md#deploy-the-operator

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt bpradipt merged commit c954cfa into confidential-containers:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants