tests/git-helper.sh: fix yq checking #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
stevenhorsman
approved these changes
Jan 30, 2024
Oh true, I missed that. @wainersm could you please update the commit message? |
`[ ! command -v jq &> /dev/null ]` doesn't work for checking the existing of jq because if enclosed in `[]` it won't check the return code of `command`. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
wainersm
force-pushed
the
fix_git_helper.sh
branch
from
6135fa3
to
2306239
Compare
|
ops... fixed the commit message! Thanks @stevenhorsman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ! command -v jq &> /dev/null ]doesn't work for checking the existing of yq because if enclosed in[]it won't check the return code ofcommand.Found this problem when running the CI jobs for PR #338.
I don't know why on previous execution jq existed on the system so that we didn't catch the issue before.