GHA: Remove {pre,post}-action steps for self-hosted runners #403
Conversation
The following hooks:
- ACTIONS_RUNNER_HOOK_JOB_STARTED
- ACTIONS_RUNNER_HOOK_JOB_COMPLETED
could perfectly replace the existing {pre,post}-action scripts
and will make a workflow independent of the runner context.
This commit wipes out all GHA steps where the actions are triggered.
Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
There was a problem hiding this comment.
Yep, those env variables seems to do exactly that so once the workers are configured it should be fine removing them here (as far as the {pre,post}_action.sh does not require some extra knowledge about the PR that wouldn't be available in the hooks but I think that shouldn't be the case, rigth?)
Yes, |
|
@BbolroC AMD SEV and SNP Coco runners are ready. Please go ahead |
The following hooks:
could perfectly replace the existing {pre,post}-action scripts and will make a workflow independent of the runner context. This PR wipes out all GHA steps where the actions are triggered.
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com
@AdithyaKrishnan please let me know when the runner for SEV/SNP is ready for this. I will ask for review when you guys are ready. Thanks.