Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Bump controller-gen to v0.15.0 #406

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Aug 5, 2024

A version of controller-gen is quite old and fails to run with the latest go:

panic: runtime error: invalid memory address or nil pointer dereference

This PR updates the package to the latest version.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

A version of controller-gen is quite old and fails to run with the latest go:

```
panic: runtime error: invalid memory address or nil pointer dereference
```

This commit updates the package to the latest version.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC
Copy link
Member Author

BbolroC commented Aug 5, 2024

This PR will be used to resolve a CI issue on s390x for #405 . Please do not review this until there is an update that the issue is resolved.

@bpradipt
Copy link
Member

bpradipt commented Aug 5, 2024

This PR will be used to resolve a CI issue on s390x for #405 . Please do not review this until there is an update that the issue is resolved.

@BbolroC typically you'll be needed to update other k8s deps as well so that they are in sync.

@bpradipt
Copy link
Member

bpradipt commented Aug 5, 2024

This PR will be used to resolve a CI issue on s390x for #405 . Please do not review this until there is an update that the issue is resolved.

@BbolroC typically you'll be needed to update other k8s deps as well so that they are in sync.

Scratch that.. It can be done as a separate PR and need not be clubbed with this one.

@BbolroC
Copy link
Member Author

BbolroC commented Aug 5, 2024

@BbolroC typically you'll be needed to update other k8s deps as well so that they are in sync.

@bpradipt Hi, could you elaborate more on this? You meant the changes like f4980bf?

@BbolroC
Copy link
Member Author

BbolroC commented Aug 5, 2024

Scratch that.. It can be done as a separate PR and need not be clubbed with this one.

Yeah, it would be great to deal with other dependencies in a separate PR. Thanks.

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @BbolroC!

@fidencio fidencio merged commit 2aede24 into confidential-containers:main Aug 5, 2024
23 of 24 checks passed
@BbolroC BbolroC deleted the bump-controller-gen branch August 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants