Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Change label from s390x to s390x-large #408

Merged

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Aug 6, 2024

Recently, an additional s390x runner was added to the organization. However, it is insufficient for running the operator e2e tests and will function as a supplementary builder.

This commit changes the label for the platform from s390x to s390x-large to differentiate the existing runner.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and I can see the labels are also updated, let me merge this.

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the instance is used in RUNNING_INSTANCE so that part needs to be addressed. Sorry for acking this a bit too quickly...

Also I grepped for the s390x and couldn't find any other uses, where exactly will the pure s390x machine tag be used?

Recently, an additional s390x runner was added to the organization.
However, it is insufficient for running the operator e2e tests and
will function as a supplementary builder.

This commit changes the label for the platform from s390x to s390x-large
to differentiate this runner.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC
Copy link
Member Author

BbolroC commented Aug 6, 2024

Also I grepped for the s390x and couldn't find any other uses, where exactly will the pure s390x machine tag be used?

Good catch, by the way. I appreciate it.

Let me explain in an easy way:

2 runners for s390x are registered to the organization like:

  • s390x-runner-01 with a label s390x and s390x-large
  • s390x-runner-02 with a label s390x

A runner (2 runners) labeled with s390x is used for building artifacts/running unit tests for trustee, cloud-api-adaptor and guest-components while a runner with s390x-large can only serve an operator e2e test plus other upcoming e2e tests (e.g. cloud-api-adaptor).

@ldoktor
Copy link
Contributor

ldoktor commented Aug 6, 2024

Also I grepped for the s390x and couldn't find any other uses, where exactly will the pure s390x machine tag be used?

A runner labeled with s390x is used for building artifacts/running unit tests for trustee, cloud-api-adaptor and guest-components.

Good catch, by the way. I appreciate it.

Thanks, so IIUC it's not used in this repository, but you want to keep the tags in sync with the other repositories under this organization? That sounds reasonable.

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should treat all the places.

@BbolroC BbolroC merged commit 6b249fd into confidential-containers:main Aug 6, 2024
13 checks passed
@BbolroC BbolroC deleted the change-runner-label-s390x branch August 6, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants