release: changes to publish 0.9.0 in operator hub #410
Conversation
| @@ -5686,17 +5686,22 @@ spec: | |||
| description: This specifies the RuntimeClasses that need to be | |||
| created, with its name and an associated snapshotter to be used | |||
| items: | |||
| description: RuntimeClass holds the name and the snapshotter | |||
There was a problem hiding this comment.
I'm not exactly sure how this works, but re-running this on your PR I'm getting many more changes to this file. I tried doing it fresh on the main branch and that also brought many more changes to this manifest. Is this expected, did some dependency changed in the mean-time?
There was a problem hiding this comment.
@wainersm could you please elaborate a bit on this? I'm getting completely different results by running the make bundle IMG=quay.io/confidential-containers/operator:v0.9.0
docs/OPERATOR_HUB.md
Outdated
| @@ -34,7 +34,7 @@ Follow the steps: | |||
|
|
|||
| 5. Copy the bundle directory to the community-operators repository directory. On the example below I got the community-operators repository cloned to `../../../github.com/k8s-operatorhub/community-operators`: | |||
| ```shell | |||
| cp -r bundle ../../../github.com/k8s-operatorhub/community-operators/operators/cc-operator/${TARGET_RELEASE} | |||
| cp -r bundle/* ../../../github.com/k8s-operatorhub/community-operators/operators/cc-operator/${TARGET_RELEASE} | |||
There was a problem hiding this comment.
Well the old one works well if the target dir does not exists. The new one only works when the target dir exists. So I'd suggest either keeping the old one but adding rm -rf ../../../github.com/k8s-operatorhub/community-operators/operators/cc-operator/${TARGET_RELEASE} (which I favour as we ensure all previous files are cleaned) or the new-one but adding mkdir -p ../../../github.com/k8s-operatorhub/community-operators/operators/cc-operator/${TARGET_RELEASE}.
Alternatively we could use rsync, which is slightly more predictable ;-)
There was a problem hiding this comment.
(another benefit of rm is that it would complain if the parent dir won't exists (eg. someone uses incorrect number of ../) while mkdir -p simply creates everything...)
| dest_dir="../../../github.com/k8s-operatorhub/community-operators/operators/cc-operator/${TARGET_RELEASE}" | ||
| rm -rf "$dest_dir" | ||
| mkdir "$dest_dir" | ||
| cp -r bundle/* "$dest_dir" |
There was a problem hiding this comment.
Perhaps unnecessarily too complex but does the job :-)
There was a problem hiding this comment.
yeah, in the end I made it more complicated :(
|
To be precise, this is what I'm getting after running the make bundle IMG=quay.io/confidential-containers/operator:v0.9.0 which makes me wonder why is it so different. |
|
Ahh, I see, it's just reformatting the strings. |
Updated the operator hub bundle for the 0.9.0 release. First bumped VERSION in Makefile then the new bundle was generated as: ``` $ make bundle IMG=quay.io/confidential-containers/operator:v0.9.0 ``` Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
We want to copy the sub-folder of bundle into the cc-operator/${TARGET_RELEASE}
folder.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
|
Only rebased to pick up #413 |
I submitted the k8s-operatorhub/community-operators#4787 to publish 0.9.0 bundle in operator hub and coco's operator landing page in hub is already updated (see https://operatorhub.io/operator/cc-operator)
Here I'm sending the changes I did to publish it as well as a few fixes to docs.