Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GH runners fixes #428

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Aug 30, 2024

The first commit fixes the workflow after the instance name changed to contain . in the version. The second commit adds the new jobs to the CI documentation.

the RUNNING_INSTANCE contains the '.', therefore the checks should also
contain the '.' in the ubuntu version.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldoktor
Copy link
Contributor Author

ldoktor commented Sep 1, 2024

I can see 2 acks, all the CI checks passed except the one this is fixing, let me merge this so we get some coverage in nightlies...

@ldoktor ldoktor merged commit 39324bd into confidential-containers:main Sep 1, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants