Review TODOs / FIXMEs

[maurolacy]

Before the mainnet release version, let's review all the TODOs and FIXMEs in the code base (tgrade, poe-contracts, and tgrade-contracts, at least).

The outcome of this issue must be a referenced list of TODOs / FIXMEs, with some evaluation of their importance / requirement for Mainnet launch, and follow-up issues for the important cases.

A quick search:

todo/TODO:

• app/genesis_integration_test.go: // todo (Alex): enable require.NoError(t, twasmGs.ValidateBasic())
• app/export.go: WithBlockTime(time.Now().UTC()) // todo (Alex): check if there is any way to get the last block time
• scripts/protocgen.sh:--doc_opt=./docs/proto/protodoc-markdown.tmpl,proto-docs.md \
• x/poe/stakingadapter/keeper.go: // todo: return self delegation of validator
• x/poe/stakingadapter/keeper.go: // todo: handle for validator operator's self delegation
• x/poe/stakingadapter/keeper.go: // todo: handle for validator operator's self delegation
• x/poe/stakingadapter/keeper.go: // todo: handle for validators self delegations
• x/poe/module.go: // todo: add PoE validation
• x/twasm/contract/incoming_msgs.go: // todo (Alex): check how a client update is done now. this also needs to go into the contracts
• x/twasm/contract/incoming_msgs.go: // todo (Alex): SubstituteClientId: proxy.ClientId,
• x/twasm/contract/incoming_msgs.go: var proxy = struct { // todo: better use wasmvmtypes.MigrateMsg when names match
• x/twasm/contract/incoming_msgs_test.go: // todo (Alex):fix also in contracts!! SubstituteClientId: ib,
• x/twasm/abci.go: panic(err) // todo (reviewer): this will break consensus
• go.mod: // TODO Remove it: Remove go.mod replace line for gin-gonic/gin cosmos/cosmos-sdk#10409
• testing/fee_test.go: // TODO: no more fees are distributed. Rather they are held in a new contract to be withdrawn.
• third_party/proto/confio/proofs.proto: bytes key = 1; // TODO: remove this as unnecessary??? we prove a range
• third_party/proto/confio/proofs.proto: bytes key = 1; // TODO: remove this as unnecessary??? we prove a range
• x/poe/contract/tg4_stake.go:// TODO: add pagination support here!
• x/poe/contract/tgrade_valset.go: // TODO: add this if you want it, not in current code
• x/poe/contract/tgrade_valset.go:// TODO: add pagination support
• x/poe/contract/tgrade_valset.go: // TODO: this is just a placeholder trying to get 100
• x/poe/contract/tgrade_oc_proposals.go: // TODO: clarify this format
• x/poe/bootstrap.go: // TODO: allow to configure the other types.