Address todo comments #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage 57.66% 57.66%
=======================================
Files 73 73
Lines 5447 5447
=======================================
Hits 3141 3141
Misses 1994 1994
Partials 312 312
|
maurolacy
approved these changes
May 12, 2022
| @@ -128,7 +128,7 @@ replace ( | |||
| // Use the cosmos-flavored keyring library | |||
| github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76 | |||
| // Fix upstream GHSA-h395-qcrw-5vmq vulnerability. | |||
| // TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | |||
| // Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | |||
There was a problem hiding this comment.
Up to you, but I would leave the TODO label. It's good for quickly finding / flagging these things.
There was a problem hiding this comment.
This todo is not actionable currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #355
Fixed or moved todo into new github issues
Note integration test todo is fixed in #361