Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #214

Merged
merged 22 commits into from
Dec 22, 2019
Merged

Develop #214

merged 22 commits into from
Dec 22, 2019

Commits on Dec 21, 2019

  1. [Midified] seed data 변경

    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    90fe0dd View commit details
    Browse the repository at this point in the history

  2. [hotfix] workMusic ObjectId miss

    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    23bd63c View commit details
    Browse the repository at this point in the history

  3. [Hotfix] 파일 다운로드 방식 변경 

    보안상 문제로 웹에서 Object Storage의 주소를 그대로 노출하지 않고 서버로 받은 Buffer Array 값을 받아옴
받아온 버퍼값을 base64 형태로 변환하여 사용함
    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    52ff20a View commit details
    Browse the repository at this point in the history

  4. [Hotfix] 배경화면 이미지 base64 -> blob 데이터로 변경 

    URL.revokeObjectURL() 은 URL.createObjectURL() 을 통해 생성한 기존 URL을 해제함.
revokeObjectURL을 통해 해제하지 않으면 기존 URL을 유효하다고 판단하고 자바스크립트 엔진에서 GC 되지 않음.
Blob URL 은 생성된 window의 document 에서만 유효하기 때문에
다른 window 에서 재활용될 수 없으며, URL의 수명이 한정되어 있기 떄문에 file:URL 과 다르게 보안 이슈에서 벗어날 수 있음
출처: https://heropy.blog/2019/02/28/blob/ , https://gracefullight.dev/2017/01/16/javascript%EB%A1%9C-%EB%A1%9C%EC%BB%AC%EC%97%90-%EC%9D%B4%EB%AF%B8%EC%A7%80-%EB%8B%A4%EC%9A%B4%EB%A1%9C%EB%93%9C/
    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    b291011 View commit details
    Browse the repository at this point in the history

  5. [Hotfix] 카드에 걸린 링크 수정

    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    ef37ae3 View commit details
    Browse the repository at this point in the history

  6. [Hotfix] 카드에 hover 시 css 추가

    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    9eb844b View commit details
    Browse the repository at this point in the history

  7. [Hotfix] 음악 카드 link 위치 조정

    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    a76cf01 View commit details
    Browse the repository at this point in the history

  8. [Feat] 프로필 사진 수정 

    프로필 사진을 수정할 수 있음
    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    0e79da6 View commit details
    Browse the repository at this point in the history

  9. [Modified] 프로필 이미지 수정 

    css 수정
    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    40092ed View commit details
    Browse the repository at this point in the history

  10. [Modified] redux global dispatch로 이미지 변경 반영 

    즉시 반영됨
    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    7020914 View commit details
    Browse the repository at this point in the history

  11. [Modified] 이미지 변경 완료후 redirect 추가

    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    e60f65e View commit details
    Browse the repository at this point in the history

  12. [Hotfix] 중복 데이터 삭제

    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    3377b5a View commit details
    Browse the repository at this point in the history

  13. [Refacotor] 삼항 연산자를 사용함

    @jominjimail
    jominjimail committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    8b8f188 View commit details
    Browse the repository at this point in the history

  14. [Hotfix] 크롬에서 지원되지 않는 image 태그 삭제

    @Junow
    Junow committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    bad6d97 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. [Hotfix] 음악 업로드 소켓 알림 추가

    @Junow
    Junow committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    cb9c3fa View commit details
    Browse the repository at this point in the history

  2. Merge pull request #208 from connect-foundation/hotfix/junow/wallpape… 

    …r-download

Hotfix/junow/wallpaper download
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    540fd73 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #210 from connect-foundation/hotfix/junow/card-lin… 

    …k-to-profile

Hotfix/junow/card link to profile
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    f592cf2 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #212 from connect-foundation/hotfix/junow/notifica… 

    …tions

[Hotfix] 음악 업로드 소켓 알림 추가
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    e74a8ba View commit details
    Browse the repository at this point in the history

  5. Merge pull request #211 from connect-foundation/reviewed/jmj/week5 

    Reviewed/jmj/week5
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    8a00888 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #207 from connect-foundation/hotfix/jmj/seed-data 

    [Midified] seed data 변경
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    0dedd4f View commit details
    Browse the repository at this point in the history

  7. [Hotfix] credential 문제 해결

    @jominjimail
    jominjimail committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    ba6ef54 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #213 from connect-foundation/hotfix/withCredential… 

    …-CORS

[Hotfix] credential 문제 해결
    SuphremeCH authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    3bd5906 View commit details
    Browse the repository at this point in the history