Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #281 : Select : prompt is no longer displayed #282

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

tbergerd
Copy link
Contributor

Hello,

I extracted the recomputation of the page into a separate method to fix the default selection not being on the first page without hiding the prompt.

@@ -42,6 +42,16 @@ impl<'a> Paging<'a> {
}
}

pub fn update_page(&mut self, cursor_pos: usize) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : I marked it pub for consistency, otherwise I'd have made it pub(crate). Doesn't matter here because module is private.

@pksunkara pksunkara merged commit c5b4084 into console-rs:master Sep 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants