Skip to content

Commit

Permalink
Remove deprecated NodeGetId before 1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
saad-ali committed Nov 8, 2018
1 parent c62adb3 commit a8170a7
Show file tree
Hide file tree
Showing 3 changed files with 274 additions and 456 deletions.
21 changes: 0 additions & 21 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -67,20 +67,9 @@ service Node {
rpc NodeGetVolumeStats (NodeGetVolumeStatsRequest)
returns (NodeGetVolumeStatsResponse) {}

// NodeGetId is being deprecated in favor of NodeGetInfo and will be
// removed in CSI 1.0. Existing drivers, however, may depend on this
// RPC call and hence this RPC call MUST be implemented by the CSI
// plugin prior to v1.0.
rpc NodeGetId (NodeGetIdRequest)
returns (NodeGetIdResponse) {
option deprecated = true;
}

rpc NodeGetCapabilities (NodeGetCapabilitiesRequest)
returns (NodeGetCapabilitiesResponse) {}

// Prior to CSI 1.0 - CSI plugins MUST implement both NodeGetId and
// NodeGetInfo RPC calls.
rpc NodeGetInfo (NodeGetInfoRequest)
returns (NodeGetInfoResponse) {}
}
Expand Down Expand Up @@ -1093,16 +1082,6 @@ message VolumeUsage {
// Units by which values are measured. This field is REQUIRED.
Unit unit = 4;
}
message NodeGetIdRequest {
// Intentionally empty.
}

message NodeGetIdResponse {
// The ID of the node as understood by the SP which SHALL be used by
// CO in subsequent `ControllerPublishVolume`.
// This is a REQUIRED field.
string node_id = 1;
}
message NodeGetCapabilitiesRequest {
// Intentionally empty.
}
Expand Down
Loading

0 comments on commit a8170a7

Please sign in to comment.