Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL Analysis workflow #4258

Merged
merged 2 commits into from
May 15, 2020
Merged

Add CodeQL Analysis workflow #4258

merged 2 commits into from
May 15, 2020

Conversation

estesp
Copy link
Member

@estesp estesp commented May 15, 2020

Carry #4216

Signed-off-by: Justin Hutchings jhutchings1@github.com
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

Signed-off-by: Justin Hutchings <jhutchings1@github.com>
Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 15, 2020

Build succeeded.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM - are the results visible somewhere?

@mxpv
Copy link
Member

mxpv commented May 15, 2020

cron: '0 0 * * 0' I guess we wait :)

@estesp would it make sense to apply the same trick as in #4256

@estesp
Copy link
Member Author

estesp commented May 15, 2020

@thaJeztah our repo is already enabled; findings will end up under the Security tab for our repo once this is merged and runs.

@mxpv I like that idea! Let me add a commit

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 15, 2020

Build succeeded.

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit b7cf3c6 into containerd:master May 15, 2020
@thaJeztah
Copy link
Member

@thaJeztah our repo is already enabled; findings will end up under the Security tab for our repo once this is merged and runs.

Ah, I guess I don't have access to that (at least couldn't find it so far) I do see we don't have a security policy configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants