bump up the default runtime to "io.containerd.runc.v2" #1359
Conversation
AkihiroSuda
force-pushed
the
shim-v2-runc-v2
branch
from
b3ac7c0
to
1d1802e
Compare
|
/test pull-cri-containerd-windows-cri |
|
/test pull-cri-containerd-node-e2e |
|
@jterry75 @Random-Liu thoughts on PRs that hit _unix isms. As a general rule, should we try to shadow/pair another PR to do the windows equivalent changes or make suggestions for the windows equivalent in the PR if amenable/doable. |
|
We need to make sure the Docker and containerd packages on OS distributions contain the new shim binary. |
Would be nice if we had an official line of communication for the distributions, where we could get feedback / verification. |
|
I think we can just mention that in v1.4 release note. |
|
@mikebrow Windows stuff is unrelated to this PR. Windows doesn't use |
ok removed that comment.. will address the windows config docs elsewhere. |
true...still would be nice to give them a heads up if they are not watching master changes. |
The former default runtime "io.containerd.runc.v1" won't support new features like support for cgroup v2: containerd/containerd#3726 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
shim-v2-runc-v2
branch
from
1d1802e
to
aaddaa2
Compare
|
updated docs |
cc @thaJeztah Who is maintaining Docker |
I can have a look at that one; plan was to open-source the repo soon (think there's one remaining PR for that) |
| @@ -298,7 +298,7 @@ func (c *criService) cleanupSandboxFiles(id string, config *runtime.PodSandboxCo | |||
| func (c *criService) taskOpts(runtimeType string) []containerd.NewTaskOpts { | |||
| // TODO(random-liu): Remove this after shim v1 is deprecated. | |||
| var taskOpts []containerd.NewTaskOpts | |||
| if c.config.NoPivot && runtimeType == plugin.RuntimeRuncV1 { | |||
| if c.config.NoPivot && (runtimeType == plugin.RuntimeRuncV1 || runtimeType == plugin.RuntimeRuncV2) { | |||
There was a problem hiding this comment.
We may want to cherry-pick this part into 1.3.
|
/lgtm |
Partially cherry-pick aaddaa2 (containerd#1359) containerd#1359 (comment) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
The former default runtime "io.containerd.runc.v1" won't support new features
like support for cgroup v2: containerd/containerd#3726
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp