fix: catalog conversion not handling all cases #2568

	#
	# Copyright (C) 2024 Red Hat, Inc.
	#
	# Licensed under the Apache License, Version 2.0 (the "License");
	# you may not use this file except in compliance with the License.
	# You may obtain a copy of the License at
	#
	# http://www.apache.org/licenses/LICENSE-2.0
	#
	# Unless required by applicable law or agreed to in writing, software
	# distributed under the License is distributed on an "AS IS" BASIS,
	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	# See the License for the specific language governing permissions and
	# limitations under the License.
	#
	# SPDX-License-Identifier: Apache-2.0

	name: pr-check

	on: [pull_request]

	jobs:
	lint-format-unit:
	name: linter, formatters and unit tests / ${{ matrix.os }}
	runs-on: ${{ matrix.os }}
	timeout-minutes: 40
	strategy:
	fail-fast: false
	matrix:
	os: [windows-2022, ubuntu-22.04, macos-12]
	steps:
	- uses: actions/checkout@v4

	- uses: pnpm/action-setup@v4
	name: Install pnpm
	with:
	run_install: false

	- uses: actions/setup-node@v4
	with:
	node-version: 20
	cache: 'pnpm'

	- name: Execute pnpm
	run: pnpm install

	- name: Run linter
	run: pnpm lint:check

	- name: Run formatter
	run: pnpm format:check

	- name: Run unit tests
	run: pnpm test:unit

	- name: Run typecheck
	run: pnpm typecheck

	- name: Run svelte check
	run: pnpm svelte:check

	# Check we don't have changes in git
	- name: Check no changes in git
	if: ${{ matrix.os=='ubuntu-22.04'}}
	run: \|
	if ! git diff --exit-code; then
	echo "Found changes in git"
	exit 1
	fi

Provide feedback