Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe: Add to recipe quick action buttons in the header #470

Open
slemeur opened this issue Mar 8, 2024 · 6 comments
Open

Recipe: Add to recipe quick action buttons in the header #470

slemeur opened this issue Mar 8, 2024 · 6 comments
Assignees

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 8, 2024

We should be consistent with the other screens we have and the other behavior we have in podman desktop.

This is what a user has, when going to containers: there is an header with a set of actions.
Screenshot 2024-03-08 at 11 54 04

For the Recipe, everything is in a new widget:
Screenshot 2024-03-08 at 11 55 08

If I'm on a small screen, I might even miss some of the actions.

I think we should have in the header:

  • Status of the recipe: is it running not running
  • Button to start it
  • Button to stop it
  • Button to remove it
  • Button to open in IDE
  • Button to open the sample AI App
@slemeur slemeur added this to the 1.1. milestone Mar 8, 2024
@axel7083 axel7083 modified the milestones: 1.1, 1.2 May 2, 2024
@bovem
Copy link

bovem commented May 14, 2024

Hey @axel7083 I would like to work on this issue.

@slemeur
Copy link
Contributor Author

slemeur commented May 14, 2024

Sure thing @bovem !

@axel7083 axel7083 assigned bovem and unassigned axel7083 May 14, 2024
@axel7083
Copy link
Contributor

Hey @axel7083 I would like to work on this issue.

Done @bovem keep us updated on your progress :) !

@bovem
Copy link

bovem commented May 29, 2024

Hey @axel7083 I had few queries.

  1. I went through the documentation and contribution docs and tried to test the UI updates with minor changes. I followed the steps here: https://github.com/containers/podman-desktop-extension-ai-lab?tab=readme-ov-file#contributing

Here are the commands I executed

cd podman-desktop-extension-ai-lab
yarn install
yarn build
cd ../podman-desktop
yarn watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend

# and because I am testing the frontend changes in a different terminal window I executed the following commands
cd ../podman-desktop-extension-ai-lab
yarn watch

But I noticed that only a few times (sometimes only once) the updates done in *.svelte files inside the frontend package are reflected in the podman desktop UI live preview. Is there something wrong in the steps performed above?
Can you share the steps you perform while testing the UI changes on the extension?

  1. I noticed PR feat(application): adding start stop actions #1122 was merged recently. Are the buttons added for start, stop, etc. in the pull request have to be moved to the header?

@axel7083
Copy link
Contributor

But I noticed that only a few times (sometimes only once) the updates done in *.svelte files inside the frontend package are reflected in the podman desktop UI live preview. Is there something wrong in the steps performed above? Can you share the steps you perform while testing the UI changes on the extension?

Hey ! Thanks for reaching out, testing frontend changes of an extension in watch mode is actually a bit difficult sadly !

On my side I often only run the first command yarn watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend but when I want to apply some changes I am doing the following steps

  • Go to extension page (podman desktop) and stop AI Lab
  • Inside the AI Lab folder, run yarn build
  • Once build finish, in the extension page, start ai lab
  • The new changes (frontend and backend) will be applied
  1. I noticed PR feat(application): adding start stop actions #1122 was merged recently. Are the buttons added for start, stop, etc. in the pull request have to be moved to the header?

There is a component named ApplicationActions.svelte, and I think this is the one that should be placed in the header, so you should not have to worry much about those, as it is a standalone component :)

@feloy
Copy link
Contributor

feloy commented May 29, 2024

But I noticed that only a few times (sometimes only once) the updates done in *.svelte files inside the frontend package are reflected in the podman desktop UI live preview. Is there something wrong in the steps performed above? Can you share the steps you perform while testing the UI changes on the extension?

Hey ! Thanks for reaching out, testing frontend changes of an extension in watch mode is actually a bit difficult sadly !

On my side I often only run the first command yarn watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend but when I want to apply some changes I am doing the following steps

  • Go to extension page (podman desktop) and stop AI Lab
  • Inside the AI Lab folder, run yarn build
  • Once build finish, in the extension page, start ai lab
  • The new changes (frontend and backend) will be applied

Same steps for me, expect that I run yarn watch in the frontend folder, so you don't need to rebuild it manually)

(I do not run it from the top directory, as it will build backend and frontend, and the command yarn watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend is already building the backend)

cd ../podman-desktop-extension-ai-lab/packages/frontend
yarn watch

@nichjones1 nichjones1 removed this from the 1.2 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants