Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application): adding start stop actions #1122

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented May 27, 2024

What does this PR do?

Following #1114, this PR adds the possibility to start/stop an application (pod). To be able to keep it stopped, without deleting it.

⚠️ We have a lack of transition state, we might want to add them in a separate PR to improve the user experience

Notable changes

  • renaming deleteApplication to removeApplication (refact api)
  • moving containerEngine pod related call to the PodManager instead of ApplicationManager (ease testing)
  • creating requestStartApplication studioApi method
  • creating requestStopApplication studioApi method

Screenshot / video of UI

application-manager-start-stop.mp4

What issues does this PR fix or reference?

Fixes #1070, #691

How to test this PR?

  • Unit tests has been provided

Manually

  • Start a recipe, go to Running page, stop, start, restart, remove

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners May 27, 2024 10:56
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 linked an issue May 27, 2024 that may be closed by this pull request
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the recipe details page if you click on start or stop, the actions menu is not refreshed.
In the gif below i click stop, the pod is correctly stopped but i don't see the start action
stop_not_removed

packages/backend/src/managers/applicationManager.ts Outdated Show resolved Hide resolved
packages/frontend/src/lib/ApplicationActions.svelte Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083
Copy link
Contributor Author

On the recipe details page if you click on start or stop, the actions menu is not refreshed. In the gif below i click stop, the pod is correctly stopped but i don't see the start action

Yes I was able to replicate, I fixed it ! Thanks for noticing

@axel7083 axel7083 requested a review from lstocchi May 28, 2024 13:57
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!! Thanks!! LGTM

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 merged commit 2acebad into containers:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running recipe does not have a stop action Only running AI Apps are displayed
2 participants