chore: adopt SettingsNavItem ui component + light mode #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
feloy
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
The choice of color seems good to me (the difference between secondary-nav-text and secondary-nav-header-text is small, but it can be considered later by @ekidneyrh).
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adopt the SettingsNavItem from the ui library + changing the colors to properly use dark/light theme
Screenshot / video of UI
Dark
Light
What issues does this PR fix or reference?
Fixes #974
How to test this PR?