fix: display error message from chat conversation #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
axel7083
reviewed
Jul 5, 2024
Signed-off-by: lstocchi <lstocchi@redhat.com>
axel7083
approved these changes
Jul 8, 2024
jeffmaury
requested changes
Jul 8, 2024
Signed-off-by: lstocchi <lstocchi@redhat.com>
|
@jeffmaury are you good with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds capabilities to display error messages during a chat. So far we just printed the errors in the console, but they are useful to guide the user.
I extended the messages that a conversation includes. So far, we just had ChatMessages, but we could also have ErrorMessages. The only thing i'm not sure about is how to display them, so i chose to use what we have now (just show the newest error message if it's the last message of the conversation), but it could be very easy to display them as part of the conversation so when you scroll up you can see the error you received for an old input. Waiting to hear your preference.
Screenshot / video of UI
What issues does this PR fix or reference?
it resolves #1083 and #1021
How to test this PR?