Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to systeminformation #1371

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jul 15, 2024

What does this PR do?

Require for #1280

Remove the requirements on winreg to use the nice and wonderful systeminformation package. It is multi platform, and is well made.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1281

How to test this PR?

  • tests are covering the change

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners July 15, 2024 12:59
@axel7083
Copy link
Contributor Author

axel7083 commented Jul 15, 2024

@feloy @jeffmaury I need a tester on MAC

Could you do the following after having installed systeminformation npm package

$: node
$> const si = require('systeminformation');
$> await si.graphics()

And send me the output of the last command. Thanks

@axel7083 axel7083 requested review from feloy and lstocchi July 15, 2024 14:49
@feloy
Copy link
Contributor

feloy commented Jul 15, 2024

> await si.graphics()
{
  controllers: [
    {
      vendor: 'Apple',
      model: 'Apple M3 Pro',
      bus: 'Built-In',
      vramDynamic: true,
      vram: null,
      deviceId: '',
      vendorId: '0x05ac',
      external: false,
      cores: '18',
      metalVersion: ''
    }
  ],
  displays: [
    {
      vendor: 'HP',
      vendorId: '220e',
      model: 'HP 27w',
      productionYear: '2019',
      serial: '1010101',
      displayId: '2',
      main: true,
      builtin: false,
      connection: null,
      sizeX: null,
      sizeY: null,
      pixelDepth: null,
      resolutionX: 1920,
      resolutionY: 1080,
      currentResX: 1920,
      currentResY: 1080,
      positionX: -1728,
      positionY: 0,
      currentRefreshRate: 60
    },
    {
      vendor: 'Apple',
      vendorId: '610',
      model: 'Color LCD',
      productionYear: '0',
      serial: 'fd626d62',
      displayId: '1',
      main: false,
      builtin: true,
      connection: 'Internal',
      sizeX: null,
      sizeY: null,
      pixelDepth: null,
      resolutionX: 3456,
      resolutionY: 2234,
      currentResX: 1728,
      currentResY: 1117,
      positionX: 0,
      positionY: 0,
      currentRefreshRate: 120
    }
  ]
}

@axel7083
Copy link
Contributor Author

thanks @feloy, I added the Apple vendor to the list !

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 enabled auto-merge (squash) July 16, 2024 08:14
@axel7083 axel7083 merged commit 69e764f into containers:main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace winreg with systeminformation
3 participants