Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create notification on user catalog issue #1413

Merged

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding notification when the catalog is malformed or wrong version is used.

Screenshot / video of UI

Screencast.from.2024-07-22.15-03-45.mp4

using old catalog version
image

malformed catalog
image

What issues does this PR fix or reference?

Fixes #1394

How to test this PR?

  • unit tests has been provided

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners July 22, 2024 13:07
@axel7083 axel7083 requested review from feloy and lstocchi July 22, 2024 13:07
MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
Co-authored-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the notification 🥳

@axel7083
Copy link
Contributor Author

LGTM, thanks for adding the notification 🥳

Thanks for the reading proof, I'm very bad at writing documentation!

MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
Co-authored-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested a review from jeffmaury July 23, 2024 07:28
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 enabled auto-merge (squash) July 23, 2024 07:31
@axel7083 axel7083 merged commit 0a9a4ca into containers:main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid catalog format should warn the user
3 participants