Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt DropDownMenuItem UI component #371

Closed
Tracked by #368
jeffmaury opened this issue Apr 24, 2024 · 0 comments · Fixed by #709
Closed
Tracked by #368

Adopt DropDownMenuItem UI component #371

jeffmaury opened this issue Apr 24, 2024 · 0 comments · Fixed by #709

Comments

@jeffmaury
Copy link
Contributor

jeffmaury commented Apr 24, 2024 •
edited
Loading

Depends on containers/podman-desktop#6918

See also containers/podman-desktop#5757
@jeffmaury jeffmaury mentioned this issue Apr 24, 2024
Closed
13 tasks
deboer-tim added a commit that referenced this issue Aug 6, 2024
@deboer-tim
chore: light mode for delete button, remove drop down
ccd93d0 
We cannot complete #376 because the issue to provide the component has stalled:
containers/podman-desktop#6898

In the meantime we can do two things:
- Pick up light mode support by copying the current code from Podman Desktop.
- Remove the menu property, so that we can remove the unused dependency on the
  the DropdownMenuItem component. (if we need dropdown support in the future,
  we should use/require the component)

Related to #376.
Part of #536.
Fixes #371.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Aug 6, 2024
Merged
cdrage pushed a commit that referenced this issue Aug 6, 2024
@deboer-tim
chore: light mode for delete button, remove drop down (#709)
7df2443 
We cannot complete #376 because the issue to provide the component has stalled:
containers/podman-desktop#6898

In the meantime we can do two things:
- Pick up light mode support by copying the current code from Podman Desktop.
- Remove the menu property, so that we can remove the unused dependency on the
  the DropdownMenuItem component. (if we need dropdown support in the future,
  we should use/require the component)

Related to #376.
Part of #536.
Fixes #371.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: light mode for delete button, remove drop down containers/podman-desktop-extension-bootc
1 participant
@jeffmaury