Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form page shadow doesn't extend past header #7549

Closed
deboer-tim opened this issue Jun 10, 2024 · 2 comments · Fixed by #7733
Closed

Form page shadow doesn't extend past header #7549

deboer-tim opened this issue Jun 10, 2024 · 2 comments · Fixed by #7733
Assignees
Labels

Comments

@deboer-tim
Copy link
Contributor

Bug description

The shadow that should extend down the full left column is only in the header for form pages, including Help, Troubleshooting, Build, etc.

Including screen cap from light mode as it is much more obvious:
Screenshot 2024-06-10 at 10 15 20 AM

Operating system

macOS 14.5

Installation Method

None

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

No response

@axel7083
Copy link
Contributor

After some investigation, the problem is that the shadown is created by the parent component here FormPage.svelte.

<div class="flex flex-col w-full h-full shadow-pageheader">

But lower in the hierarchy, it define the background color, overlapping the shadow

<div class="flex w-full h-full bg-[var(--pd-content-bg)] overflow-auto">

Possible solution

Absolute shadow

We could add <div class="z-50 shadow-pageheader w-full h-full absolute"/> inside the FormPage, which would create a shadown overlay, solving the problem.

image

Make the FormPage background the same as the content

We seems to already use the same color for the header and content, let's define it next to the shadown.

Same result

image

cc @feloy @deboer-tim

@deboer-tim
Copy link
Contributor Author

These used to have different colors for header and content, which is probably why there was a distinction so we didn't notice this issue. @ekidneyrh changed to use a single color in forms when @feloy was implementing light mode here, so my preference is the last option. I think we need to remove the 1px horizontal line too, it just looks out of place now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants