Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): formpage missing content shadow #7733

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

As suggested by @deboer-tim in #7549 (comment) since we are using a single color for the header and the content, removing the border and moving up the bg-color to avoid hidden the shadow

Screenshot / video of UI

Before After
image image

What issues does this PR fix or reference?

Fixes #7549

How to test this PR?

  • Tests are covering the bug fix or the new feature

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 🚀 LGTM!!

@axel7083 axel7083 merged commit 3f4b98a into containers:main Jun 19, 2024
8 checks passed
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me one minute too long to review 😛 but here it is anyway: +1. Worth noting that the Troubleshooting page looks 'worse' (no line below the tabs) but I think that's a sign it should actually be a DetailsPage.

@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone Jun 19, 2024
cdrage pushed a commit to cdrage/podman-desktop that referenced this pull request Jun 19, 2024
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form page shadow doesn't extend past header
5 participants