Use FormPage for Create Playground page #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
force-pushed
the
fix-1232/form-page-create-playground
branch
from
e5fefbb
to
e683d50
Compare
axel7083
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
| light | dark |
|---|---|
LGTM, light theme header and missing shadow in dark mode will be fixed by containers/podman-desktop#7733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the "Create Playground" page to use the dedicated FormPage component instead of NavPage
Also change the background color to support light mode
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #1232
How to test this PR?
Navigate to Playgrounds > Create new playground